fix qcFailed to handle null correctly

oicr-gsi · Nov 22, 2024 · b4e8e80 · b4e8e80
1 parent cfa86b0
commit b4e8e80
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ From the project root, build runnable `.jar` file (located in `cardea-server/tar
 
 Or run server via Maven (ensure config is in cardea-server):
 
-mvn clean install && mvn spring-boot:run -pl cardea-server
+`mvn clean install && mvn spring-boot:run -pl cardea-server`
 
 The server runs on port 8080 by default. To run on a different port, add a `server.port` setting
 to your `application.properties`

diff --git a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java
@@ -195,10 +195,10 @@ private ShesmuSequencing makeShesmuSequencing(List<Sample> samples, MetricCatego
 
   private boolean getQcFailed(Sample sample) {
     Run run = sample.getRun();
-    return ((sample.getDataReviewPassed() == false)
-        || (sample.getQcPassed() == false)
-        || (run.getDataReviewPassed() == false)
-        || (run.getQcPassed() == false));
+    return ((Boolean.FALSE.equals(sample.getDataReviewPassed()))
+        || (Boolean.FALSE.equals(sample.getQcPassed()))
+        || (Boolean.FALSE.equals(run.getDataReviewPassed()))
+        || (Boolean.FALSE.equals(run.getQcPassed())));
   }
 
   private Set<String> getLimsIusIdsForShesmu(Case kase) {

diff --git a/changes/fix_qcfailed_field.md b/changes/fix_qcfailed_field.md
@@ -0,0 +1 @@
+Field on cardea detailed cases must be able to handle null values
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Field on cardea detailed cases must be able to handle null values