add qcFailed field to shesmu detailed cases #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add changelog
grapigeau
force-pushed
the
GP-4451.add_qc_failed_field
branch
from
7252bdc to
0ed35c7
Compare
djcooke
reviewed
Nov 14, 2024
cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java
Outdated
Show resolved
Hide resolved
grapigeau
force-pushed
the
GP-4451.add_qc_failed_field
branch
from
cc2e3de to
f3866a2
Compare
djcooke
approved these changes
Nov 15, 2024
Comment on lines
44
to
45
| private boolean supplemental; | ||
| private Boolean qcFailed; |
There was a problem hiding this comment.
I realize it wasn't added in this PR, but supplemental should be Boolean in the builder too
mlaszloffy
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://jira.oicr.on.ca/browse/GP-4451