Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to provide custom template directory for supplemental body #488

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

MareikeJaniak
Copy link
Collaborator

Added a way to provide a custom template directory for the supplemental.body plugin. Similar to the html_dir hook, this is all or nothing, so if a custom template dir is provided, all files must be found there. Tested on my side with an MoH sample that was analyzed with our in-house pipeline to produce a report that includes that pipeline description.

@MareikeJaniak MareikeJaniak requested a review from iainrb November 7, 2024 18:09
@iainrb iainrb changed the base branch from main to release-1.8.0 January 24, 2025 18:01
Copy link
Collaborator

@iainrb iainrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready to merge with the release-1.8.0 branch.

@MareikeJaniak MareikeJaniak marked this pull request as ready for review January 31, 2025 16:14
@MareikeJaniak MareikeJaniak merged commit 0f345f6 into release-1.8.0 Jan 31, 2025
2 checks passed
@iainrb iainrb deleted the dev-mcgill-assay branch January 31, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants