Feature: 배포 세팅 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+33
to
+35
| url: jdbc:mysql://${MYSQL_HOST:localhost}:${MYSQL_PORT:3306}/${DB_NAME:susu}?useUnicode=true&charset=utf8mb4&characterEncoding=utf8&zeroDateTimeBehavior=convertToNull | ||
| username: ${MYSQL_USERNAME:susu} | ||
| password: ${MYSQL_PASSWORD:susu} |
There was a problem hiding this comment.
application-prod.yml에 해당 셋업 진행해야 될 것 같아요!!
There was a problem hiding this comment.
prod는 default값 빼고 세팅할게요!
디비 연결 안되면 에러 터트리는게 맞을 것 같다고 생각해서요
Dockerfile
Outdated
| ARG JAR_FILE=./build/libs/*.jar | ||
| COPY ${JAR_FILE} app.jar | ||
|
|
||
| ARG PROFILE=dev |
There was a problem hiding this comment.
Suggested change
| ARG PROFILE=dev | |
| ARG PROFILE=prod |
.github/workflows/Deploy.yml
Outdated
Comment on lines
3
to
11
| on: | ||
| push: | ||
| branches: ['develop'] | ||
|
|
||
| env: | ||
| ACTIVE_PROFILE: "prod" | ||
| DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| DOCKERHUB_IMAGE_NAME: ${{ secrets.DOCKERHUB_IMAGE_NAME }} | ||
| DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }} |
There was a problem hiding this comment.
저희 staging, dev 환경 구축없이 prod 단일 운영으로 초기 논의를 했던 것 같은데요!
요기 branch 설정이 바뀌어야 될 것 같아요.
아니면, dev 환경을 별도로 분리해서 배포하는 방식으로 진행해야 될 것 같아요.
There was a problem hiding this comment.
초기진행
- prod 단일 배포
추후(서비스가 커진다는 행복회로)
- prod, staging 배포
추후(미쵸따!)
- prod, staging, dev 배포
DongGeon0908
approved these changes
Nov 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
-> cloudwatch에 서버 로그 전달되도록 연결해뒀습니다!
변경로직
ci workflow에 gradle cache 부분에서 계속 에러나서 일단 주석처리 해뒀습니다.
해결 방법 알아내면 고쳐서 다시 올려둘게요 -> 해결했어요 ㅎㅋ