-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix secure boot issue when measuring the kernel #51
Open
aplanas
wants to merge
8
commits into
okirch:main
Choose a base branch
from
aplanas:fix_bsc1219807
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug output can be missleading, as print information about the current event log, but not about the measured element, that can be different as in the kernel case. Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
If the new EFI image is in a new place, the image information stored in the parsed event should be updated, so the rehash will use this information instead of the one from the event log. Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
aplanas
force-pushed
the
fix_bsc1219807
branch
2 times, most recently
from
February 27, 2024 07:33
4fedbf8
to
e669dac
Compare
Signed-off-by: Alberto Planas <[email protected]>
aplanas
force-pushed
the
fix_bsc1219807
branch
from
February 27, 2024 07:37
e669dac
to
211502e
Compare
Communicated to shim via rhboot/shim#642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When secure boot is enabled, the device path for the kernel (PCR4) is not filled in the event log. This makes the kernel not measured and the current hash of the event log reused.
This PR provides an heuristic to detect this situation, and use the next kernel parameter as a basis to build a new candidate that will be measured.
Build on top of #47