Hide unauthorized ui #220
Merged
Hide unauthorized ui #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatter works better with this.
Start #217, #179. Remaining work depends on olin-build/ABE#214. This work is to retrieve the account info from GET /account instead of initializing it to a constant that grants all permissions; to extend withServerInfo (currently in PR #219) to verify that the account has been loaded; and to guard the Sidebar by withServerInfo.
osteele
force-pushed
the
osteele/hide-unauthorized-ui
branch
from
f1961e6 to
7079d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start #217, #179.
Remaining work depends on olin-build/ABE#214. This work is to retrieve the account info from
GET /accountinstead of initializing it to a constant that grants all permissions; to extendwithServerInfo(currently in PR #219) to verify that the account has been loaded; and to guard the Sidebar bywithServerInfo.Required
Changes must conform to these requirements:
yarn testpasses. All new and existing tests pass.yarn lintpasses. All new code follows the code style of this project.Aspirational
We don't yet require these, but they are nice to have: