Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement compatibility with merkletreejs - try 2 #29

Closed
wants to merge 23 commits into from
Closed

feat: implement compatibility with merkletreejs - try 2 #29

wants to merge 23 commits into from

Conversation

olivmath
Copy link
Owner

@olivmath olivmath commented Dec 24, 2023 •
edited
Loading

✅ Done to Review #21

  • Create test to validate root creation in MerkleTreeJs and Merkly
  • Implement optionality when creating a MerkleTree instance
  • Implement size validation in the sheets, as it is currently only supported for base 2 exponential sizes such as: 2,4,8,16,32,...
  • Implement a compatible MerkleTreeJS algorithm
  • Show compatibility with MerkleTreeJs in evidence
  • Add docs about how to use - MOVE TO Docs about new compatibility with MerkleTreeJs #30

This PR failed because have conflicts, I will break into some new PRS

@olivmath olivmath added feat Adds a feature that didn't exist before DANGER This PR will be approved/merged with some failed tests, NOT DEPLOYABLE labels Dec 24, 2023
@olivmath olivmath self-assigned this Dec 24, 2023
@olivmath olivmath mentioned this pull request Dec 24, 2023
Closed
6 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 24, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@olivmath olivmath closed this Dec 24, 2023
@olivmath olivmath deleted the feat/merkletreejs branch December 24, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@olivmath olivmath

Labels
DANGER This PR will be approved/merged with some failed tests, NOT DEPLOYABLE feat Adds a feature that didn't exist before
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olivmath