Parameters #94
Parameters #94
Conversation
|
Two quick points:
|
|
|
@aleksandra-tarkowska: added option for openjdk17/18-devel as suggested |
jburel
force-pushed
the
java-parameters
branch
5 times, most recently
from
a25b80c to
f6e1c1f
Compare
|
@pwalczysko: I have tested all the java options using travis (list below)
|
The default version installed using: apt-get -y install postgresql is 9.3. Version marked as deprecated in our requirements page.
|
All: |
|
@pwalczysko are you happy with all the changes? Could this PR being merged as is blocking me |
|
I was happy before #94 (comment). Are the 3 new commits tested by Travis ? If yes, happy to merge. |
|
@pwalczysko: 2/3 are tested by travis and |
|
Happy then, thank you. |
|
This was successfully used in ome/devspace#20. |
| #start-copy | ||
| cp setup_omero_nginx.sh ~omero | ||
| #end-copy | ||
|
|
||
| #start-install | ||
| yum -y --enablerepo=cr install nginx |
There was a problem hiding this comment.
why do we need CR? EPEL is installed in https://github.com/ome/omero-install/pull/94/files#diff-2722b62c943402fa409b2ef40375cf5dR3
from EPEL you also install nginx/1.6.3
There was a problem hiding this comment.
I will have to look into it, since we have been splitting several files
There was a problem hiding this comment.
cr is not required. so it should be removed. The version installed will be 1.6.3.
To match the recommended version cf. ome/omero-documentation#1439, we will have to follow the same approach that the one used for centos 6.
For the rest of the dependencies, we have installed the recommended version
I will update the code according
There was a problem hiding this comment.
@jburel I am not sure if I follow but for C6, changing to EPEL will install nginx 1.0.15. I am guessing is better to leave as it is (installing from Nginx repository)
There was a problem hiding this comment.
for C6, yes the version is old.
We recommend version in our requirements page for java, ice, pg etc. in the doc.
The version installed in the installation script should match what is recommended, for nginx we recommend 1.8/1.9 so that what we should/install test.
That's another reason why we are also thinking of moving the sysadmin doc under omero-install so we will hopefully keep things in synch (it has not been the case e.g pg on ubuntu!)
note that I am currently fixing the ubuntu install script since I just noticed that 1.4.6 is currently installed.
|
@aleksandra-tarkowska: nginx version installed should now be 1.8+ for centos6/7 and ubuntu1404/debian8 cf. ome/omero-documentation#1439 |
|
nginx changes have been tested via travis. |
|
@jburel there is one more file that need to be fixed https://github.com/ome/omero-install/blob/develop/linux/omero-systemd.service
@pwalczysko how did you manage to start server with PostgreSQL 9.5 if pg version is hardcoded in daemon script ? |
|
@aleksandra-tarkowska: Thanks I thought I fixed it. I will try to do that today |
The comment of mine just claims I have tried both PGVER values. Did not check the Postgres version truly installed. |
@jburel: Thanks. Let us know though, that could also be a follow on PR. |
|
Since this is also currently consumed (and someway tested) via https://github.com/openmicroscopy/devspace/pull/20/files#diff-91f78839f1da3c73c6a67587b59bc8a5R18, I would be in favor of getting this merged and point to the organization repository for the container installation. |
|
I did not have time yesterday probably better to merge this PR and fix it in a follow-up PR so we can move forward on other fronts |
|
Merging to unlock devspace. |
Add
JAVAVERparameters. Default is OpenJDK 1.8 across the various installations. This was not the case.The first 6 commits were tested by travis in PR #83
Re-organise step installation dependencies.
Update the autogenerate script.
Also Add
PGVER(for postgres) andICEVER(for ice)cc @hflynn