-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --repository-config option to set base branch for submodules #225
Conversation
FYI there are some long-standing requests for scc and omego to support a config file to save having to define common args on the command line, e.g. |
Presumably, once ome/yaclifw#7 is merged we could switch over to use it. |
I only mentioned it because of the naming of the new parameter |
Yes, it could be renamed to something more specific. Or, we could allow more than branch configuration in the future. For example, it could be extended to support per-repository filtering options etc. |
Renamed |
This reverts commit f06a5aa.
The changes proposed here make sense, are overall backwards-compatible while allowing more granularity on the control of some of the filter options via a YML configuration file. The support for file-based flexible configuration is something that has been discussed as a more generic feature (see ome/yaclifw#7) and having such a concrete driver is a good first step. Assuming the unit and integration tests pass, happy for this to be released as 0.9.0. NB: as an extra feature, should I open a PR to port to |
Testing:
https://github.com/ome/bio-formats-build.git
scc merge --repository-config=repos.yml master --no-ask --reset --update-gitmodules -D none -I user:rleigh-codelibre -v
for examplesubmodules
section alongsidebase-branch
in the submodule definition). The dict for the submodule will be passed to submoduleGitRepository
initialisation.repos.yml
example: