Fix PHP 8.2 deprecation warnings for dynamic properties. #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 has deprecated dynamically created object properties. These two instances were found while using the insert_files_for_item global helper using the Url transfer strategy. I've resolved the issue by simply adding the properties. I set the visibility to protected due to the names having leading underscores, but I could see setting them to public to ensure that there would be no broken code. I could not find any instance of the properties being used by any other code within Omeka, but I suppose there is a very slight chance a plugin could expect the side effect of the properties being created.