-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide alt text configuration options for images. #1037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kimisgold
commented
Sep 18, 2024
- Within the Appearance Settings, users can select an element that can provide alt text for files.
- Users can also write alt text via a new field on the file edit form. This field will override alt text provided by file metadata.
- Images use a blank alt by default.
- File markup no longer provides titles by default, nor populate titles using the alt attribute.
- Browse views no longer assign "presentation" roles to the record images.
* Within the Appearance Settings, users can select an element that can provide alt text for files. * Users can also write alt text via a new field on the file edit form. This field will override alt text provided by file metadata. * Images use a blank alt by default. * File markup no longer provides titles by default, nor populate titles using the alt attribute. * Browse views no longer assign "presentation" roles to the record images.
zerocrates
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
My most substantive comments relate to the fallback to an element and will be found on the settings and in the File model.
* Use metadata() in file/show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.