Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking to records of any type from Browse Tags page. #965

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions admin/themes/default/tags/browse.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<h2><?php echo __('Editing Tags'); ?></h2>

<ol>
<li><?php echo __('This number counts all records associated with a tag. Filtering "Record types" to "Items" will provide links to all items containing the tag.'); ?></li>
<li><?php echo __('This number counts all records associated with a tag. Filtering "Record Types" will provide links to all records of that type containing the tag.'); ?></li>
<li><?php echo __('To edit the tag name, click the name and begin editing, and hit "enter" to save. To cancel an edit, click the ESC key or click away from the tag.'); ?></li>
<li><?php echo __('To delete a tag, click the X. Deleting a tag will not delete the tagged records.'); ?></li>
</ol>
Expand Down Expand Up @@ -85,8 +85,8 @@
<ul class="tag-list">
<?php foreach ($tags as $tag): ?>
<li>
<?php if($browse_for == 'Item'):?>
<a href="<?php echo html_escape(url('items/browse', array('tags' => $tag->name))); ?>" class="count"><?php echo $tag['tagCount']; ?></a>
<?php if($browse_for != 'All'):?>
<?php echo link_to(strtolower(Inflector::pluralize($browse_for)), 'browse', $tag['tagCount'], array('class' => 'count'), array('tags' => $tag->name)); ?>
<?php else: ?>
<span class="count"><?php echo $tag['tagCount']; ?></span>
<?php endif; ?>
Expand Down