Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit contribution #61

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

Daniel-KM
Copy link
Contributor

Hi,

Added the possibility for a contributor to edit his/her contributions. This patch merges all previous commits.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

@patrickmj
Copy link
Contributor

It's going to be pretty tricky to sort through this many changes. There's no code conflicts reported by git, but I'm hesitant to pull in so much at once. Could you pare this down to just what 'Edit Contribution' does?

@Daniel-KM
Copy link
Contributor Author

Hi,

This patch allows the contributors to be allowed to modify their contribution. Normally, the admin board is designed for that, but I needed it for one site.

This patch contains all the previous ones, plus merge fixes, plus specific commits. If you don't want this feature, you can see #46, #47 and #48, and the #54 that contains fixes, and let #52 and #61 that are very specific.

Note that I didn't check the code in the api, because I don't use it.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

@patrickmj
Copy link
Contributor

patrickmj commented Jan 14, 2017

Since this would eventually be coming from RRCHNM, I'm still hesitant to add it all in. I'm comfortable with forks existing to meet specific needs, and people generally grabbing code that more specifically meets their needs. That's open source as it should be. But, it'd take a lot of analysis and testing to make sure it makes sense in general to propagate your user case in the base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants