-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use subgraph to pre-populate gauge options for the safe user in ui #31
feat: use subgraph to pre-populate gauge options for the safe user in ui #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, works on localhost for me!
seeing the pool name of the gauge and not the address is a great step in ux :)
this does raise a new question; what if we want to enable harvests for both?
and probably also somewhat out of scope, but i noted that even if connected to opti goerli the same gauges show up. so somewhere we should start becoming chain aware. (a subgraph will always be for a single specific chain only, for a different chain a different subgraph will be needed)
added the chain awareness in 9249a30 |
another item was planning to scope on the ui side is to allow multi-select on the options and to do a multi-call in the safe app to enable both atomically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to refresh after switching chains, in order to refresh the gauge dropdown
maybe open a separate issue for this?
because the rest lgtm and can be merged imo :) |
No description provided.