Add somatic/germline gene page #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update gene info section & Add external link icon - Add InfoTile & GeneOriginTabs
Add genomic indicators && Minor updates
Added mini-navbar
Minor changes
Add germline core proxy config
Update based on the latest design
Show protein change and allele state for germline page
jfkonecn
requested changes
Oct 23, 2024
src/main/webapp/app/Main.tsx
Outdated
| routing={this.props.routing} | ||
| windowStore={this.props.windowStore} | ||
| > | ||
| <AppRouts |
Comment on lines
+32
to
+36
| inGenePage | ||
| ? '' | ||
| : props.windowStore.isXLscreen | ||
| ? 'container' | ||
| : 'container-fluid' |
There was a problem hiding this comment.
Would CSS media queries would this be simpler than using Javascript?
There was a problem hiding this comment.
Good question. Didn't look into, inherited from the original.
There was a problem hiding this comment.
For public website, we haven't really used the @media to manage the layout. I would stick to the classname for now.
| content: ( | ||
| <div> | ||
| <OncoKBLevelIcon | ||
| size={'s2'} |
There was a problem hiding this comment.
I see this all over the code base is there a reason why you don't do "s2" instead?
There was a problem hiding this comment.
you meant why it's not a default?
|
|
||
| @inject('appStore', 'windowStore', 'routing') | ||
| @observer | ||
| export default class SomaticGermlineGenePage extends React.Component< |
There was a problem hiding this comment.
why not a functional component?
There was a problem hiding this comment.
We have a store in this class. And we manage some observables states here too.
jfkonecn
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.