Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release SOP v4 #14

Merged
merged 2 commits into from
May 30, 2024
Merged

Release SOP v4 #14

merged 2 commits into from
May 30, 2024

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented May 30, 2024

No description provided.

@zhx828 zhx828 requested a review from calvinlu3 May 30, 2024 20:41
index.html Outdated
@@ -29,6 +29,7 @@
<span id="current-version-span"></span>
</button>
<ul class="dropdown-menu" aria-labelledby="previousVersionDropdown">
<li><a class="dropdown-item" href="#" value="v4">Version 4</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there two version 3's? v3.0 and v3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support https://sop.oncokb.org/?version=v3.0 But I think I can make a slight change in script to avoid the dup. Let me work on that.

@zhx828 zhx828 changed the title Upload SOP v4 Release SOP v4 May 30, 2024
@zhx828 zhx828 requested a review from calvinlu3 May 30, 2024 21:01
Copy link
Contributor

@calvinlu3 calvinlu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhx828 zhx828 merged commit e00ef40 into master May 30, 2024
1 check passed
@zhx828 zhx828 deleted the release-v4 branch May 30, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants