Add variant recommendation page #426
Conversation
pom.xml
Outdated
| @@ -321,6 +321,11 @@ | |||
| <artifactId>firebase-admin</artifactId> | |||
| <version>9.1.1</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.googlecode.json-simple</groupId> | |||
There was a problem hiding this comment.
Do we need to add this? Will GSON work?
| @@ -22,5 +22,7 @@ public final class Constants { | |||
|
|
|||
| public static final String DEFAULT_GENE_SYNONMN_SOURCE = "cBioPortal"; | |||
|
|
|||
| public static final String ONCOKB_S3_BUCKET = "oncokb-bucket"; | |||
There was a problem hiding this comment.
@zhx828 do you want this to be an environment variable?
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| String[] data = line.split("\t"); | ||
| JSONObject jsonObject = new JSONObject(); |
| input[type='range']::-webkit-slider-thumb { | ||
| pointer-events: all; | ||
| width: var(--_thumb-size); | ||
| height: var(--_thumb-size); | ||
| border-radius: 0; | ||
| border: 0 none; | ||
| } | ||
|
|
||
| input[type='range']::-moz-range-thumb { | ||
| pointer-events: all; | ||
| width: var(--_thumb-size); | ||
| height: var(--_thumb-size); | ||
| border-radius: 0; | ||
| border: 0 none; | ||
| } |
There was a problem hiding this comment.
This is to define the appearance of the slider thumb. -webkit-slider-thumb is for Chrome and Safari, while -moz-range-thumb is for Firefox.
There was a problem hiding this comment.
According to mdn it looks like safari doesn't support this yet. (it's also in pre-release so that doesn't mean safari never will)
Does it still look good in safari?
| formatted = formatted.replace(/\.?0+$/, ''); | ||
| if (formatted.endsWith('.')) { | ||
| formatted = formatted.slice(0, -1); | ||
| } |
There was a problem hiding this comment.
Is this to needed to remove trailing zeros? let formatted = +(value * 1000).toFixed(2); should give you the same result.
There was a problem hiding this comment.
I'd like to display 100% instead of 100.00%, as it looks better. However, if it doesn't matter, I can remove it.
There was a problem hiding this comment.
It makes me nervous to use a regex since it's difficult to see if they will work the way you want them to. Does this line of code remove the extra zeros? let formatted = +(value * 1000).toFixed(2);.
| onChange: (newRange: [number, number]) => void; | ||
| } | ||
|
|
||
| export const TwoRangeSlider = ({ min, max, range, step, onChange }: RangeSliderProps) => { |
There was a problem hiding this comment.
Why is this called TwoRangeSlide, why not just Slider?
| if (!filter.value) return true; | ||
| return String(row[filter.id]).toLowerCase().includes(filter.value.toLowerCase()); |
There was a problem hiding this comment.
See if you can turn this into a function. I see the same repeated several times.
| Filter({ filter, onChange }) { | ||
| return <Input placeholder="Search" value={filter ? filter.value : ''} onChange={event => onChange(event.target.value)} />; | ||
| }, |
There was a problem hiding this comment.
Could this be made into a component? I see this code repeated in a few places.
| Filter({ filter, onChange }) { | ||
| const filterValue = filter ? filter.value : ['', '']; | ||
| return ( | ||
| <div style={{ display: 'flex', gap: '10px' }}> | ||
| <Input placeholder="Min" value={filterValue[0]} onChange={event => onChange([event.target.value, filterValue[1]])} /> | ||
| <Input placeholder="Max" value={filterValue[1]} onChange={event => onChange([filterValue[0], event.target.value])} /> | ||
| </div> | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Can this be made into a share component?
| @@ -44,6 +45,7 @@ const Routes: React.FunctionComponent<IRoutesProps> = (props: IRoutesProps) => { | |||
| <PrivateRoute exact path={PAGE_ROUTE.SEARCH} component={SearchPage} /> | |||
| <PrivateRoute path={PAGE_ROUTE.CURATION} component={CurationRoutes} hasAnyAuthorities={[AUTHORITIES.CURATOR]} /> | |||
| <PrivateRoute exact path={PAGE_ROUTE.ACCOUNT} component={Account} hasAnyAuthorities={[AUTHORITIES.USER]} /> | |||
| <PrivateRoute exact path={PAGE_ROUTE.VARIANR_REC} component={VariantRecListPage} /> | |||
There was a problem hiding this comment.
Let's add hasAnyAuthorities={[AUTHORITIES.CURATOR]}.
Could you also add authorization to the backend too?
| } | ||
|
|
||
| return ResponseEntity.ok(jsonList); | ||
| return ResponseEntity.ok(jsonArray.toString()); |
There was a problem hiding this comment.
Could you double that the content type is Content-Type: application/json; in the response header?
Code for the Variant Recommendation Page - frontend and backend implementation