xe: sdpa: Fix KQ gemm alignment for the K tensor #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
added
bug
|
make test |
umar456
force-pushed
the
uarshad/sdpa_alignment_fix
branch
from
02fd3ad to
b3bcf85
Compare
|
make test |
syurkevi
approved these changes
Dec 18, 2024
umar456
force-pushed
the
uarshad/sdpa_alignment_fix
branch
from
b3bcf85 to
cd1fd9c
Compare
|
make test |
skazakov1
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the alignment on the KQ matrix multiplication. This fixes several accuracy issues for smaller tensor sizes.