Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: codeowners: add graph team to review graph doc #2340

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

TaoLv
Copy link
Contributor

@TaoLv TaoLv commented Jan 6, 2025

I wanted to review the changes of graph document, but Github refused me to label #2301 with component:graph-api .

@TaoLv TaoLv requested a review from a team as a code owner January 6, 2025 09:49
@@ -44,6 +44,7 @@
# Documentation
*.md @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch
/doc/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch
/doc/graph/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch @oneapi-src/onednn-graph @intel-innersource/dnn-graph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) all oneapi-src codeowner teams are typically put before all their intel-innersource counterparts.

@mgouicem
Copy link
Contributor

mgouicem commented Jan 6, 2025

I wanted to review the changes of graph document, but Github refused me to label #2301 with component:graph-api .

Hi Tao, you mean GitHub refused you to add a lable or to require a review ?

@TaoLv
Copy link
Contributor Author

TaoLv commented Jan 6, 2025

I wanted to review the changes of graph document, but Github refused me to label #2301 with component:graph-api .

Hi Tao, you mean GitHub refused you to add a lable or to require a review ?

Sorry. I realized that I missed the two things together. In fact, both. GitHub did not request review from graph team for the PR, though I feel it's okay-ish. So I labeled the PR with component:graph-api manually to make sure the PR appear in our filter and get attention from the team. But Github removed the label after the PR was force-pushed. It seems that I will need another change to make the labeler work for us as well.

@mgouicem
Copy link
Contributor

mgouicem commented Jan 6, 2025

Yes if the issue is with labelling, you will have to add doc/graph to the labeller config file

@TaoLv TaoLv force-pushed the lvtao/main/doc-codeowner branch from b305e74 to 418424a Compare January 6, 2025 13:48
@TaoLv TaoLv requested a review from a team as a code owner January 6, 2025 13:48
@@ -44,6 +44,7 @@
# Documentation
*.md @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch
/doc/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch
/doc/graph/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @oneapi-src/onednn-graph @intel-innersource/dnn-doc @intel-innersource/dnn-arch @intel-innersource/dnn-graph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would make approval from any member of onednn-graph to cover documentation part as well. See a note in CODEOWNERS documentation. I would rather add you to onednn-doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks Vadim. I dropped the change for codeowner but still want to keep the change for labeler. Could you please take another look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TaoLv TaoLv force-pushed the lvtao/main/doc-codeowner branch from 418424a to fb2bbfa Compare January 7, 2025 02:52
@github-actions github-actions bot added devops Github automation and removed governance labels Jan 7, 2025
@TaoLv TaoLv merged commit 64b4c34 into main Jan 7, 2025
17 checks passed
@TaoLv TaoLv deleted the lvtao/main/doc-codeowner branch January 7, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Github automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants