-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: codeowners: add graph team to review graph doc #2340
Conversation
.github/CODEOWNERS
Outdated
@@ -44,6 +44,7 @@ | |||
# Documentation | |||
*.md @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch | |||
/doc/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch | |||
/doc/graph/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch @oneapi-src/onednn-graph @intel-innersource/dnn-graph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) all oneapi-src codeowner teams are typically put before all their intel-innersource counterparts.
Hi Tao, you mean GitHub refused you to add a lable or to require a review ? |
Sorry. I realized that I missed the two things together. In fact, both. GitHub did not request review from graph team for the PR, though I feel it's okay-ish. So I labeled the PR with |
Yes if the issue is with labelling, you will have to add doc/graph to the labeller config file |
b305e74
to
418424a
Compare
.github/CODEOWNERS
Outdated
@@ -44,6 +44,7 @@ | |||
# Documentation | |||
*.md @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch | |||
/doc/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @intel-innersource/dnn-doc @intel-innersource/dnn-arch | |||
/doc/graph/ @oneapi-src/onednn-doc @oneapi-src/onednn-arch @oneapi-src/onednn-graph @intel-innersource/dnn-doc @intel-innersource/dnn-arch @intel-innersource/dnn-graph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would make approval from any member of onednn-graph
to cover documentation part as well. See a note in CODEOWNERS documentation. I would rather add you to onednn-doc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks Vadim. I dropped the change for codeowner but still want to keep the change for labeler. Could you please take another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
418424a
to
fb2bbfa
Compare
I wanted to review the changes of graph document, but Github refused me to label #2301 with
component:graph-api
.