-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xe: Add internal tests for SDPA #2549
Open
umar456
wants to merge
5
commits into
main
Choose a base branch
from
uarshad/sdpa_internal_primitive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzarukin
reviewed
Jan 29, 2025
h-sadia
approved these changes
Jan 29, 2025
umar456
force-pushed
the
uarshad/sdpa_internal_primitive
branch
3 times, most recently
from
January 29, 2025 23:27
2f19156
to
21e4251
Compare
make test |
umar456
force-pushed
the
uarshad/sdpa_internal_primitive
branch
from
January 31, 2025 15:57
21e4251
to
b1baef1
Compare
umar456
force-pushed
the
uarshad/sdpa_internal_primitive
branch
from
February 1, 2025 01:33
b1baef1
to
574412a
Compare
github-actions
bot
added
the
platform:gpu-intel
Codeowner: @oneapi-src/onednn-gpu-intel
label
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:tests
Codeowner: @oneapi-src/onednn-arch
platform:gpu-intel
Codeowner: @oneapi-src/onednn-gpu-intel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to directly test the internal micro SDPA primitive. These tests do not access the SDPA primitive through the graph API, instead the tests are accessing the primitive through exposing a C API symbol for the primitive.
The tests are running through the gtest driver in the test_internals executable. These tests will allow us to prototype new features to the SDPA primitive and add tests before the Graph API can expose them through that API.