Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe: Add internal tests for SDPA #2549

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

umar456
Copy link
Contributor

@umar456 umar456 commented Jan 29, 2025

Description

This PR adds tests to directly test the internal micro SDPA primitive. These tests do not access the SDPA primitive through the graph API, instead the tests are accessing the primitive through exposing a C API symbol for the primitive.

The tests are running through the gtest driver in the test_internals executable. These tests will allow us to prototype new features to the SDPA primitive and add tests before the Graph API can expose them through that API.

@umar456 umar456 requested a review from a team as a code owner January 29, 2025 18:41
@github-actions github-actions bot added the component:tests Codeowner: @oneapi-src/onednn-arch label Jan 29, 2025
src/common/sdpa_test_iface.cpp Outdated Show resolved Hide resolved
src/common/sdpa_test_iface.cpp Outdated Show resolved Hide resolved
tests/gtests/internals/sdpa_internal.hpp Outdated Show resolved Hide resolved
tests/gtests/internals/sdpa_internal.hpp Outdated Show resolved Hide resolved
tests/gtests/internals/sdpa_internal.hpp Outdated Show resolved Hide resolved
tests/gtests/internals/sdpa_internal.hpp Outdated Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Outdated Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Outdated Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Outdated Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Outdated Show resolved Hide resolved
tests/gtests/internals/test_sdpa.cpp Show resolved Hide resolved
@umar456 umar456 force-pushed the uarshad/sdpa_internal_primitive branch 3 times, most recently from 2f19156 to 21e4251 Compare January 29, 2025 23:27
@umar456
Copy link
Contributor Author

umar456 commented Jan 29, 2025

make test
disable benchnn_all
disable test_device_cpu
enable test_device_gpu

@umar456 umar456 force-pushed the uarshad/sdpa_internal_primitive branch from 21e4251 to b1baef1 Compare January 31, 2025 15:57
@umar456 umar456 force-pushed the uarshad/sdpa_internal_primitive branch from b1baef1 to 574412a Compare February 1, 2025 01:33
@umar456 umar456 requested a review from a team as a code owner February 1, 2025 01:33
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests Codeowner: @oneapi-src/onednn-arch platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants