src: attr: quantization refactor (part 2) #2570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
|
make test |
dzarukin
force-pushed
the
dzarukin/refactor_quant_zp
branch
2 times, most recently
from
9333c44 to
dc6de43
Compare
|
make test |
dzarukin
force-pushed
the
dzarukin/refactor_quant_zp
branch
from
dc6de43 to
cf92bf9
Compare
|
This seems to fail for AArch64. Is this still under development? |
Yeah, there's one piece left: update gtests, and it should be good. |
dzarukin
force-pushed
the
dzarukin/refactor_quant_zp
branch
from
cf92bf9 to
e31d1fb
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move zero_points to quant_entry_t abstraction.
Same deal as in #2270.
With this change the interface will be completely aligned between those two.
The next part will clean up skip_mask_t flags and, probably, introduce a single base class for scales and zero-points to inherit from to avoid code duplication and new features enabling in the future.