Terraform v4 upgrade (#222)

* Update Task Version to V4

* update providers.tf version numbers

* Add resource provider registrations = none

* Health check eviction time default value

* storage name character limit

* remove $ from sql server password generation

devops/Terraform/modules/random_password_in_key_vault/module.tf

@@ -5,7 +5,7 @@ resource "random_password" "sql_server_password" {
   min_numeric      = 1
   min_upper        = 1
   min_special      = 1
-  override_special = "!#$%*-_+?@.[]()"
+  override_special = "!#%*-_+?@.[]()"
 
   lifecycle {
     ignore_changes = [

devops/Terraform/providers.tf

@@ -3,11 +3,11 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "3.116.0"
+      version = "4.10.0"
     }
     azuread = {
       source  = "hashicorp/azuread"
-      version = "2.53.1"
+      version = "3.0.2"
     }
     mssql = {
       source  = "betr-io/mssql"
@@ -22,6 +22,7 @@ terraform {
 
 provider "azurerm" {
   subscription_id = "5c41ba40-6ca2-4e8a-9646-d3585df38b5a"
+  resource_provider_registrations = "none"
 
   features {
     resource_group {

devops/Terraform/storage.tf

@@ -1,5 +1,5 @@
 resource "azurerm_storage_account" "stage" {
-  name                             = "${replace(local.resource_prefix, "-", "")}storage"
+  name                             = "${replace(replace(local.resource_prefix, "-", ""), "backend", "be")}storage" # must be between 3 & 24 chars
   resource_group_name              = azurerm_resource_group.stage.name
   location                         = azurerm_resource_group.stage.location
   account_tier                     = "Standard"

devops/Terraform/web-api.tf

@@ -40,6 +40,7 @@ resource "azurerm_linux_web_app" "web_api" {
     use_32_bit_worker     = false
     websockets_enabled    = true
     health_check_path     = "/health/ready"
+    health_check_eviction_time_in_min = 10
     application_stack {
       dotnet_version = "8.0"
     }

devops/infra-build-tfp-steps.yml

@@ -23,7 +23,7 @@ steps:
     inputs:
       terraformVersion: latest
 
-  - task: TerraformTaskV3@3
+  - task: TerraformTaskV4@4
     displayName: 'Initialize TF'
     inputs:
       workingDirectory: '${{parameters.tfWorkingDirectory}}'
@@ -44,7 +44,7 @@ steps:
     displayName: 'Select TF Workspace'
     workingDirectory: '${{parameters.tfWorkingDirectory}}'
 
-  - task: TerraformTaskV3@3
+  - task: TerraformTaskV4@4
     name: Terraform_Plan
     displayName: 'Build TF Plan'
     inputs:

devops/rollout-deploy-stage-jobs.yml

@@ -101,7 +101,7 @@ jobs:
               inputs:
                 terraformVersion: latest
 
-            - task: TerraformTaskV3@3
+            - task: TerraformTaskV4@4
               displayName: "Apply TF Plan"
               inputs:
                 workingDirectory: "$(tf.workingDirectory)"