Merge branch 'main' into release

.github/workflows/dotnet.yml

@@ -18,11 +18,11 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Setup .NET
-      uses: actions/setup-dotnet@v1
+      uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 9.0.x
+        global-json-file: global.json
     - name: Restore dependencies
       run: dotnet restore
     - name: Build

Directory.Build.props

@@ -1,15 +1,15 @@
 <Project>
     <PropertyGroup>
-        <TargetFramework>net9.0</TargetFramework>
+        <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
         <LangVersion>13</LangVersion>
         <Nullable>enable</Nullable>
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <Authors>ONIXLabs</Authors>
         <NeutralLanguage>en</NeutralLanguage>
         <Copyright>Copyright © ONIXLabs 2020</Copyright>
         <RepositoryUrl>https://github.com/onix-labs/onixlabs-dotnet</RepositoryUrl>
-        <Version>11.0.0</Version>
-        <PackageVersion>11.0.0</PackageVersion>
-        <AssemblyVersion>11.0.0</AssemblyVersion>
+        <Version>11.1.0</Version>
+        <PackageVersion>11.1.0</PackageVersion>
+        <AssemblyVersion>11.1.0</AssemblyVersion>
     </PropertyGroup>
 </Project>

OnixLabs.Core.UnitTests/ObjectExtensionTests.cs

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 using System;
+using System.Threading.Tasks;
 using OnixLabs.Core.UnitTests.Data;
 using Xunit;
 
@@ -223,4 +224,33 @@ public void ToStringOrNullShouldProduceExpectedResultWhenObjectIsNotNull()
         // Then
         Assert.Equal(expected, actual);
     }
+
+    [Fact(DisplayName = "ToSuccessResult should produce the expected result")]
+    public void ToSuccessResultShouldProduceTheExpectedResult()
+    {
+        // Given
+        const string expected = "abc";
+
+        // When
+        Result<string> result = expected.ToSuccessResult();
+
+        // Then
+        Success<string> success = Assert.IsType<Success<string>>(result);
+        Assert.Equal(expected, success.Value);
+    }
+
+    [Fact(DisplayName = "ToSuccessResultAsync should produce the expected result")]
+    public async Task ToSuccessResultAsyncShouldProduceTheExpectedResult()
+    {
+        // Given
+        const string expected = "abc";
+
+        // When
+        Task<string> task = Task.FromResult(expected);
+        Result<string> result = await task.ToSuccessResultAsync();
+
+        // Then
+        Success<string> success = Assert.IsType<Success<string>>(result);
+        Assert.Equal(expected, success.Value);
+    }
 }

OnixLabs.Core.UnitTests/OptionalEqualityComparerTests.cs

@@ -158,7 +158,7 @@ public void OptionalEqualityComparerEqualsShouldReturnFalseWhenComparingNonIdent
     public void OptionalEqualityComparerGetHashCodeShouldReturnZeroWhenOptionalValueIsNone()
     {
         // Given
-        const int expected = default;
+        const int expected = 0;
         Optional<string> optional = Optional<string>.None;
         OptionalEqualityComparer<string> comparer = new();
 

OnixLabs.Core.UnitTests/OptionalTests.cs

@@ -42,8 +42,8 @@ public void OptionalNoneShouldProduceExpectedResult()
     public void OptionalOfShouldProduceExpectedResultForImplicitDefaultValues()
     {
         // Given / When
-        Optional<int> number = Optional<int>.Of(default);
-        Optional<string> text = Optional<string>.Of(default);
+        Optional<int> number = Optional<int>.Of(0);
+        Optional<string> text = Optional<string>.Of(null);
 
         // Then
         Assert.True(Optional<int>.IsNone(number));
@@ -100,7 +100,7 @@ public void OptionalOfShouldProduceExpectedResultForNullNullableStructValues()
     {
         // Given / When
         Optional<int> number = Optional<int>.Of((int?)null);
-        Optional<Guid> identifier = Optional<Guid>.Of((Guid?)default);
+        Optional<Guid> identifier = Optional<Guid>.Of((Guid?)null);
 
         // Then
         Assert.False(number.HasValue);
@@ -171,7 +171,7 @@ public void OptionalImplicitOperatorShouldProduceExpectedSomeResult()
     public void OptionalImplicitOperatorShouldProduceExpectedNoneResult()
     {
         // Given / When
-        const string? value = default;
+        const string? value = null;
         Optional<string> optional = value;
 
         // Then
@@ -297,7 +297,7 @@ public void OptionalSomeGetHashCodeShouldProduceExpectedResult()
     public void OptionalNoneGetHashCodeShouldProduceExpectedResult()
     {
         // Given
-        const int expected = default;
+        const int expected = 0;
         Optional<int> optional = Optional<int>.None;
 
         // When
@@ -335,8 +335,8 @@ public void OptionalNoneGetValueOrDefaultShouldProduceExpectedResult()
         string? actualText = text.GetValueOrDefault();
 
         // Then
-        Assert.Equal(default, actualNumber);
-        Assert.Equal(default, actualText);
+        Assert.Equal(0, actualNumber);
+        Assert.Equal(null, actualText);
     }
 
     [Fact(DisplayName = "Optional Some.GetValueOrDefault with default value should produce the expected result.")]

OnixLabs.Core.UnitTests/PreconditionTests.cs

@@ -217,13 +217,13 @@ public void CheckNotNullOfValueTypeShouldThrowInvalidOperationExceptionWhenCondi
     {
         // Given
         int? expected = null;
-        int actual = default;
+        int actual = 0;
 
         // When
         Exception exception = Assert.Throws<InvalidOperationException>(() => actual = CheckNotNull(expected));
 
         // Then
-        Assert.Equal(default, actual);
+        Assert.Equal(0, actual);
         Assert.Equal("Argument must not be null.", exception.Message);
     }
 
@@ -593,13 +593,13 @@ public void RequireNotNullOfValueTypeShouldThrowInvalidOperationExceptionWhenCon
     {
         // Given
         int? expected = null;
-        int actual = default;
+        int actual = 0;
 
         // When
         Exception exception = Assert.Throws<ArgumentNullException>(() => actual = RequireNotNull(expected));
 
         // Then
-        Assert.Equal(default, actual);
+        Assert.Equal(0, actual);
         Assert.Equal("Argument must not be null.", exception.Message);
     }
 

OnixLabs.Core.UnitTests/ResultExtensionTests.cs

@@ -211,7 +211,7 @@ public async Task ResultGetValueOrDefaultAsyncShouldReturnDefaultWhenResultIsFai
         string? actualText = await textTask.GetValueOrDefaultAsync();
 
         // Then
-        Assert.Equal(default, actualNumber);
+        Assert.Equal(0, actualNumber);
         Assert.Null(actualText);
     }
 
@@ -364,8 +364,8 @@ public async Task ResultGetValueOrNoneAsyncShouldReturnOptionalValueWhenResultIs
     public async Task ResultGetValueOrNoneAsyncShouldReturnNoneWhenResultIsSuccessAndValueIsNone()
     {
         // Given
-        Result<int> numberResult = Result<int>.Success(default);
-        Result<string> textResult = Result<string>.Success(default!);
+        Result<int> numberResult = Result<int>.Success(0);
+        Result<string> textResult = Result<string>.Success(null!);
 
         // When
         Optional<int> actualNumber = await Task.FromResult(numberResult).GetValueOrNoneAsync();