Update the instruction for building multiple accelerators #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tung D. Le <[email protected]>
tungld
commented
Jan 17, 2025
| @@ -10,7 +11,8 @@ if (ONNX_MLIR_ACCELERATORS) | |||
| add_subdirectory(${t}) | |||
|
|
|||
| # If the accelerator can be built | |||
| if (${t}_ENABLED) | |||
| string(TOUPPER ${t} T) | |||
There was a problem hiding this comment.
Just to normalize accelerator names to upper case, since all cmake variables seem to be in upper case.
|
Jenkins Linux amd64 Build #16133 [push] Update the instruction f... started at 18:44 |
|
Jenkins Linux ppc64le Build #15162 [push] Update the instruction f... started at 20:02 |
|
Jenkins Linux s390x Build #16135 [push] Update the instruction f... started at 19:44 |
|
Jenkins Linux amd64 Build #16133 [push] Update the instruction f... passed after 1 hr 25 min |
|
Jenkins Linux s390x Build #16135 [push] Update the instruction f... passed after 1 hr 36 min |
|
Jenkins Linux ppc64le Build #15162 [push] Update the instruction f... passed after 2 hr 34 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
docs/AddCustomAccelerators.mdwith instructions to build multiple accelerators.