Merge pull request #1217 from oom-ai/chore/fmt-sprintf

chore: replace %s with %q
oom-ai · Feb 28, 2022 · d7a4256 · d7a4256
2 parents 6200c7b + dc7b48e
commit d7a4256
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/internal/database/offline/bigquery/table_schema.go b/internal/database/offline/bigquery/table_schema.go
@@ -5,16 +5,17 @@ import (
 	"fmt"
 
 	"cloud.google.com/go/bigquery"
+	"github.com/spf13/cast"
+	"google.golang.org/api/iterator"
+
 	"github.com/oom-ai/oomstore/internal/database/dbutil"
 	"github.com/oom-ai/oomstore/internal/database/offline"
 	"github.com/oom-ai/oomstore/pkg/errdefs"
 	"github.com/oom-ai/oomstore/pkg/oomstore/types"
-	"github.com/spf13/cast"
-	"google.golang.org/api/iterator"
 )
 
 func (db *DB) TableSchema(ctx context.Context, opt offline.TableSchemaOpt) (*types.DataTableSchema, error) {
-	q := fmt.Sprintf(`SELECT column_name, data_type FROM %s.INFORMATION_SCHEMA.COLUMNS WHERE table_name = "%s"`, db.datasetID, opt.TableName)
+	q := fmt.Sprintf(`SELECT column_name, data_type FROM %s.INFORMATION_SCHEMA.COLUMNS WHERE table_name = %q`, db.datasetID, opt.TableName)
 	rows, err := db.Query(q).Read(ctx)
 	if err != nil {
 		return nil, errdefs.WithStack(err)

diff --git a/internal/database/online/cassandra/import.go b/internal/database/online/cassandra/import.go
@@ -64,7 +64,7 @@ func buildInsertStatement(tableName string, columns []string) string {
 		valueFlags = append(valueFlags, "?")
 	}
 
-	return fmt.Sprintf(`INSERT INTO "%s" (%s) VALUES (%s)`,
+	return fmt.Sprintf(`INSERT INTO %q (%s) VALUES (%s)`,
 		tableName,
 		dbutil.QuoteFn(Backend)(columns...),
 		strings.Join(valueFlags, ","))