Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor asr/tts components #1083

Merged
merged 32 commits into from
Dec 31, 2024
Merged

Refactor asr/tts components #1083

merged 32 commits into from
Dec 31, 2024

Conversation

Spycsh
Copy link
Member

@Spycsh Spycsh commented Dec 27, 2024

Successive PR to #1041, but on an upstream branch for cooperative CI with examples.

Description

Refactor asr/tts comp

  • adapt to use controller (register/activate) to replace the original wrapper layer as opea_asr_microservice.py under comps/asr/src (Same for tts)
  • move original dependency/ to src/integrations/dependency (Same for tts)
  • Unify to use OpenAI input/response format, keep the old code forward compatible by keep the router /v1/asr for dependency (Same for tts)
  • add registering params num_trials timeout and change code to sync to avoid activate failure
  • merge dataprep/multimedia2text/audio2text folder into asr

Take ASR folder structure as an example:

.
├── deployment
│   ├── docker_compose
│   │   ├── compose_whisper_hpu.yaml
│   │   └── compose_whisper.yaml
│   └── kubernetes
└── src
    ├── check_asr_server.py
    ├── Dockerfile
    ├── integrations
    │   ├── dependency
    │   │   └── whisper
    │   │       ├── check_whisper_server.py
    │   │       ├── Dockerfile
    │   │       ├── Dockerfile.intel_hpu
    │   │       ├── __init__.py
    │   │       ├── whisper_model.py
    │   │       └── whisper_server.py
    │   ├── opea_whisper_asr.py
    ├── opea_asr_microservice.py
    ├── README.md
    └── requirements.txt

Issues

#988
#1007

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

WIP

@Spycsh Spycsh changed the title Refactor asr/tts comp Refactor asr/tts components Dec 27, 2024
@Spycsh Spycsh mentioned this pull request Dec 27, 2024
9 tasks
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/proto/api_protocol.py 96.13% <100.00%> (+<0.01%) ⬆️

Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chensuyue chensuyue merged commit a19c222 into main Dec 31, 2024
13 of 22 checks passed
@chensuyue chensuyue deleted the source/refactor_multimedia branch December 31, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants