Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lvms #1096

Merged
merged 45 commits into from
Jan 13, 2025
Merged

Refactor lvms #1096

merged 45 commits into from
Jan 13, 2025

Conversation

Spycsh
Copy link
Member

@Spycsh Spycsh commented Jan 2, 2025

Description

Refactor lvm comp

Issues

opea-project/GenAIExamples#1333

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

na

Tests

UT

@Spycsh Spycsh requested a review from lvliang-intel as a code owner January 2, 2025 03:05
@Spycsh Spycsh changed the title refactor lvm Refactor lvms Jan 2, 2025
@Spycsh
Copy link
Member Author

Spycsh commented Jan 3, 2025

  1. Deprecated original wrappers opea/lvm-tgi, opea/lvm-llava-svc, opea/lvm-video-llama and merged functionalities in opea/lvm

  2. Original video-llama-lvm-server renamed as lvm-video-llama

Copy link
Collaborator

@ZePan110 ZePan110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need resolve conflict

@Spycsh
Copy link
Member Author

Spycsh commented Jan 13, 2025

video-llama has a issue with latest transformers 4.48.0

Traceback (most recent call last):
  File "/home/user/comps/lvms/src/integrations/dependency/video-llama/server.py", line 23, in <module>
    from transformers import TextIteratorStreamer, set_seed
  File "<frozen importlib._bootstrap>", line 1055, in _handle_fromlist
  File "/home/user/.local/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1806, in __getattr__
    value = getattr(module, name)
  File "/home/user/.local/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1805, in __getattr__
    module = self._get_module(self._class_to_module[name])
  File "/home/user/.local/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1819, in _get_module
    raise RuntimeError(
RuntimeError: Failed to import transformers.generation.streamers because of the following error (look up to see its traceback):
unsupported operand type(s) for |: 'type' and 'NoneType'

@@ -0,0 +1,60 @@
# Copyright (C) 2024 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts rename and code structure update will be in another PR.

@chensuyue chensuyue merged commit feef30b into main Jan 13, 2025
22 of 23 checks passed
@chensuyue chensuyue deleted the source/refactor_lvm branch January 13, 2025 05:07
@joshuayao joshuayao linked an issue Jan 14, 2025 that may be closed by this pull request
smguggen pushed a commit to opea-aws-proserve/GenAIComps that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] ERAG refactor - lvms
3 participants