Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TEI embedding docker compose health check issue #1133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lvliang-intel
Copy link
Collaborator

Description

Fix TEI embedding docker compose health check issue

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Local test and CI test

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashahba ashahba added this to the v1.2 milestone Jan 10, 2025
@fidencio
Copy link

Would it be possible to add the description of what's being fixed and how it's being fixed as part of the commit message?

By doing so, we're helping our future selves to solve similar issues, and also to understand better why a change was made just by navigating through the project's history.

@rbrugaro
Copy link
Collaborator

@fidencio There were two issues: first, the TEI Docker image doesn't include the curl command, causing the health check to fail; second, the health check requires using host_ip instead of localhost. Since the CI test script uses docker run instead of the docker-compose.yaml, these issues were not identified earlier. This PR solves both

@rbrugaro
Copy link
Collaborator

Needed for PR #16666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants