Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon bedrock #875

Closed
wants to merge 20 commits into from
Closed

Conversation

Vihanth
Copy link

@Vihanth Vihanth commented Nov 8, 2024

Description

adding amazon bedrock to access anthropic.claude-3-5-haiku LLM.

Issues

New feature

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vihanth for this PR.

comps/llms/text-generation/bedrock/entrypoint.sh Outdated Show resolved Hide resolved
comps/llms/text-generation/bedrock/llm.py Show resolved Hide resolved
comps/llms/text-generation/bedrock/requirements.txt Outdated Show resolved Hide resolved
comps/llms/text-generation/bedrock/llm.py Show resolved Hide resolved
@srinarayan-srikanthan
Copy link
Collaborator

bedrock microservice with / without streaming is working. But when integrated with megaservice only non streaming is working. streaming is giving empty string as output.

@chensuyue
Copy link
Collaborator

The pre-commit.ci robot is not allowed to commit into your org, so please fix the issue locally.
image

@chensuyue
Copy link
Collaborator

pip install pre-commit
pre-commit install
image

@joshuayao joshuayao linked an issue Nov 19, 2024 that may be closed by this pull request
@Vihanth Vihanth requested a review from ashahba December 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants