Add helm starter chart for developing helm chart #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
force-pushed
the
helm-chart-starter
branch
from
a8ed171 to
bc37842
Compare
|
Let's hold this until we've got the helm charts directory layout figured out |
lianhao
force-pushed
the
helm-chart-starter
branch
from
bc37842 to
fe34c8c
Compare
eero-t
suggested changes
Dec 18, 2024
There was a problem hiding this comment.
I think some instructions on using the template are also needed.
It could e.g. state which classes service needs to use, for it to have v1/health_check endpoint for the probes, and that services always need to handle SIGTERM, to avoid lost requests on service scale down.
dev/helm-chart-starter/templates/horizontal-pod-autoscaler.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+25
to
+29
| ## Values | ||
|
|
||
| | Key | Type | Default | Description | | ||
| | ------------------------------- | ------ | ------------------------------------ | ---------------------- | | ||
| | global.HUGGINGFACEHUB_API_TOKEN | string | `insert-your-huggingface-token-here` | Hugging Face API token | |
There was a problem hiding this comment.
I think this needs a link to a shared documentation explaining all the common keys in the values file (proxies etc). Such doc could be split to sections based on how commonly given keys need to be specified by the user.
lianhao
force-pushed
the
helm-chart-starter
branch
from
fe34c8c to
fca6e49
Compare
Helm starter chart pack can be used to create helm chart for new services. Signed-off-by: Lianhao Lu <[email protected]>
lianhao
force-pushed
the
helm-chart-starter
branch
from
fca6e49 to
6a14f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helm starter chart pack can be used to create helm chart for new services.
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.