Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt refactor comps #1340

Merged
merged 19 commits into from
Jan 8, 2025
Merged

Adapt refactor comps #1340

merged 19 commits into from
Jan 8, 2025

Conversation

WenjiaoYue
Copy link
Collaborator

@WenjiaoYue WenjiaoYue commented Jan 3, 2025

Description

Adapt refactor comps, fix path issue

Issues

opea-project/GenAIComps#1095

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

no.

Tests

CI pass.

Copy link

github-actions bot commented Jan 3, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

WenjiaoYue and others added 3 commits January 3, 2025 13:27
Signed-off-by: WenjiaoYue <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>
@chensuyue
Copy link
Collaborator

Please search all the examples, this one is missed.

dockerfile: comps/reranks/src/Dockerfile

Signed-off-by: WenjiaoYue <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>
WenjiaoYue and others added 2 commits January 6, 2025 22:03
Copy link
Collaborator

@minmin-intel minmin-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: WenjiaoYue <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>
WenjiaoYue and others added 7 commits January 7, 2025 14:56
Signed-off-by: WenjiaoYue <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>
Signed-off-by: WenjiaoYue <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>
@chensuyue chensuyue merged commit 9970605 into main Jan 8, 2025
24 of 34 checks passed
@chensuyue chensuyue deleted the wenjiao/Adapt_refactor_comps branch January 8, 2025 02:36
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Jan 15, 2025
Signed-off-by: WenjiaoYue
Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants