Fix Domain Access Issue in Latest Vite Version #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test version of Vite When users use the new version of Vite, the UI cannot be accessed via domain names due to Vite's new rules. This fix adds the corresponding parameters according to Vite's new rules, ensuring that users can access the frontend via domain names when building the UI. Fixes #1441
WenjiaoYue
requested review from
lvliang-intel,
Spycsh,
XinyuYe-Intel,
letonghan,
rbrugaro,
ashahba,
XinyaoWa,
lkk12014402 and
minmin-intel
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
WenjiaoYue
requested review from
xiguiw and
lianhao
and removed request for
ashahba,
Spycsh,
minmin-intel,
XinyaoWa,
rbrugaro,
XinyuYe-Intel,
letonghan and
lkk12014402
|
Should we also add the same things for react UI? Because I see the same file |
The react version is written by an other contributor. I think we can make sure the svelte version is correct first. I will verify the react version later and then add it. |
lvliang-intel
approved these changes
Jan 21, 2025
lianhao
approved these changes
Jan 21, 2025
xiguiw
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the restriction on using domain names when users are using the latest version of Vite
When users use the new version of Vite, the UI cannot be accessed via domain names due to Vite's new rules. This fix adds the corresponding parameters according to Vite's new rules, ensuring that users can access the frontend via domain names when building the UI.
Fixes #1441
Issues
#1441
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
the latest vite version
Tests
CI pass.