Add method to display all DHW scenarios for the currently set RCP/SSP #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/analysis/feature_set.jl
Outdated
| """ | ||
| function _filter_constants(scens::DataFrame)::DataFrame | ||
| varying_cols = [] | ||
| for (i, col) in enumerate(eachcol(scens)) |
There was a problem hiding this comment.
Is the loop here is more efficient than something like findall(dropdims(sum(diff(Matrix(scens);dims=1),dims=1),dims=1).==0.0) ?
There was a problem hiding this comment.
Adjusted to use a comprehension instead of mutating an existing vector.
I had to get something done quickly so what was there before was the easiest way without using too much brain power.
This should address your concern re efficiency while balancing for code readability.
Rosejoycrocker
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title.
I've also taken the opportunity to flesh out the docstring for
ADRIA.viz.dhw_scenario(dom, some_id)which was missing.