Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dto for gethardwareinfo #412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1,320 −66

Merge branch 'main' into dtogethardwareinfo2

b61b5c4
Select commit
Loading
Failed to load commit list.
Open

feat: use dto for gethardwareinfo #412

Merge branch 'main' into dtogethardwareinfo2
b61b5c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2024 in 0s

69.99% (+0.86%) compared to 983e14e

View this Pull Request on Codecov

69.99% (+0.86%) compared to 983e14e

Details

Codecov Report

Attention: Patch coverage is 97.12919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (983e14e) to head (b61b5c4).

Files with missing lines Patch % Lines
internal/controller/http/v2/devicemanagement.go 50.00% 5 Missing and 1 partial ⚠️
internal/mocks/wsv1_mocks.go 0.00% 5 Missing ⚠️
internal/usecase/devices/info.go 99.74% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   69.12%   69.99%   +0.86%     
==========================================
  Files          80       80              
  Lines        9040     9442     +402     
==========================================
+ Hits         6249     6609     +360     
- Misses       2465     2509      +44     
+ Partials      326      324       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov