Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add Argo CD Agent integration solution #740

Conversation

mikeshng
Copy link
Member

@mikeshng mikeshng commented Dec 5, 2024

Summary

Add a solution doc for integration with the Argo CD Agent project.

Related issue(s)

open-cluster-management-io/addon-contrib#23

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 December 5, 2024 07:02
@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

looks good!


```shell
git clone [email protected]:open-cluster-management-io/addon-contrib.git
cd argocd-agent-addon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, we should consider put this into the helm repo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a great idea.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0c77b29 into open-cluster-management-io:main Dec 5, 2024
14 checks passed
@mikeshng mikeshng deleted the add-solution-argocd-agent branch December 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants