-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ✨ feature feat: add registration drivers to cluster manager helm chart template. #810
Conversation
f0b21d1
to
3b6e6a1
Compare
3b6e6a1
to
7dc22c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to make some changes to https://github.com/open-cluster-management-io/ocm/blob/main/deploy/cluster-manager/chart/cluster-manager/values.yaml as well?
I don't see the registrationDrivers
key in that file.
/assign @qiujian16 /assign @zhiweiyin318 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
==========================================
- Coverage 63.84% 63.80% -0.04%
==========================================
Files 193 193
Lines 18673 18673
==========================================
- Hits 11921 11915 -6
- Misses 5772 5776 +4
- Partials 980 982 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ramesh Krishna <[email protected]>
0e00162
to
9fd23e0
Compare
Fixed. Have added value to the values.yaml as required. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ramekris3163 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eeb4ab3
into
open-cluster-management-io:main
Summary
Changed cluster manager helm template to support setting the required registrationDrivers if present.
Related issue(s)
Ref: #514