Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ✨ feature feat: add registration drivers to cluster manager helm chart template. #810

Conversation

ramekris3163
Copy link
Contributor

@ramekris3163 ramekris3163 commented Jan 17, 2025

Summary

Changed cluster manager helm template to support setting the required registrationDrivers if present.

Related issue(s)

Ref: #514

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 January 17, 2025 22:42
@ramekris3163 ramekris3163 changed the title feat: add registration drivers to cluster manager helm chart template. ❇️ feat: add registration drivers to cluster manager helm chart template. Jan 17, 2025
@ramekris3163 ramekris3163 changed the title ❇️ feat: add registration drivers to cluster manager helm chart template. ✨ ✨ feature feat: add registration drivers to cluster manager helm chart template. Jan 17, 2025
@ramekris3163 ramekris3163 force-pushed the feat/add_registration_drivers_to_helm_template branch from f0b21d1 to 3b6e6a1 Compare January 17, 2025 22:47
@ramekris3163 ramekris3163 reopened this Jan 17, 2025
@ramekris3163 ramekris3163 force-pushed the feat/add_registration_drivers_to_helm_template branch from 3b6e6a1 to 7dc22c1 Compare January 17, 2025 22:52
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to make some changes to https://github.com/open-cluster-management-io/ocm/blob/main/deploy/cluster-manager/chart/cluster-manager/values.yaml as well?

I don't see the registrationDrivers key in that file.

@mikeshng
Copy link
Member

/assign @qiujian16

/assign @zhiweiyin318

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (f62242d) to head (9fd23e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   63.84%   63.80%   -0.04%     
==========================================
  Files         193      193              
  Lines       18673    18673              
==========================================
- Hits        11921    11915       -6     
- Misses       5772     5776       +4     
- Partials      980      982       +2     
Flag Coverage Δ
unit 63.80% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramekris3163 ramekris3163 force-pushed the feat/add_registration_drivers_to_helm_template branch from 0e00162 to 9fd23e0 Compare January 18, 2025 01:47
@ramekris3163
Copy link
Contributor Author

Do you need to make some changes to https://github.com/open-cluster-management-io/ocm/blob/main/deploy/cluster-manager/chart/cluster-manager/values.yaml as well?

I don't see the registrationDrivers key in that file.

Fixed. Have added value to the values.yaml as required.

@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2025
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ramekris3163

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eeb4ab3 into open-cluster-management-io:main Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants