addressed feedback from PR review

Signed-off-by: Gergely Brautigam <[email protected]> - addressed sync lock missing to ensure concurrent calls - addressed code formatting issues - addressed missing Logger transport augmentation - addressed formatting and language issues - removed unused docker code
open-component-model · Dec 17, 2024 · 31c23e8 · 31c23e8
1 parent 024a606
commit 31c23e8
Show file tree

Hide file tree

Showing 14 changed files with 62 additions and 2,093 deletions.
diff --git a/api/oci/extensions/repositories/ocireg/repository.go b/api/oci/extensions/repositories/ocireg/repository.go
@@ -137,6 +137,7 @@ func (r *RepositoryImpl) getResolver(comp string) (oras.Resolver, error) {
 	}
 
 	client := retry.DefaultClient
+	client.Transport = ocmlog.NewRoundTripper(retry.DefaultClient.Transport, logger)
 	if r.info.Scheme == "https" {
 		// set up TLS
 		//nolint:gosec // used like the default, there are OCI servers (quay.io) not working with min version.
@@ -157,11 +158,9 @@ func (r *RepositoryImpl) getResolver(comp string) (oras.Resolver, error) {
 				return rootCAs
 			}(),
 		}
-		client = &http.Client{
-			Transport: retry.NewTransport(&http.Transport{
-				TLSClientConfig: conf,
-			}),
-		}
+		client.Transport = ocmlog.NewRoundTripper(retry.NewTransport(&http.Transport{
+			TLSClientConfig: conf,
+		}), logger)
 	}
 
 	authClient := &auth.Client{

diff --git a/api/tech/docker/README.md b/api/tech/docker/README.md
diff --git a/api/tech/docker/errors/errors.go b/api/tech/docker/errors/errors.go
diff --git a/api/tech/docker/fetcher.go b/api/tech/docker/fetcher.go