priority for CLI registration options #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Whats the concrete use case for this? I dont believe we have anyone asking for this (yet). Even if we do Im missing documentation on it (e.g. why would someone want to use it? and how is a priority specified, for example I could only know how it is used after looking into the test cases in code)
|
The problem was reported by @hilmarf . He wanted to register an OCI Uploader, which was never used because of its default priority. |
hilmarf
reviewed
Nov 5, 2024
cmds/ocm/commands/ocmcmds/common/options/optutils/registration.go
Outdated
Show resolved
Hide resolved
hilmarf
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The CLI registration options (--downloader, --uploader) now support an additional optional priority segment.
The new format is
<name>[:<artifact type>[:<media type>[:<prio>]]]=<JSON target config>The priority so far was the default priority also used for the builtin registrations. There competing registrations
from the CLI (or config) were never used.
Therefore
Which issue(s) this PR fixes
Fixes #1046