Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sure that version bumping happens everytime #1090

Conversation

jakobmoellerdev
Copy link
Contributor

What this PR does / why we need it

This makes sure that we dont only do a patch bump on main after a successful branch cut, but we also do a bump on the release branch (for the next z / patch version) after the minor has been released.

Creates a shared workflow that can be called from other workflows.

Which issue(s) this PR fixes

Ensures more automated workflows after the rework from #995

Example run at https://github.com/open-component-model/ocm-cicd-playground/actions/runs/11838213132/job/32986884073

@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner November 15, 2024 06:22
@github-actions github-actions bot added the chore label Nov 15, 2024
hilmarf
hilmarf previously approved these changes Nov 15, 2024
@hilmarf hilmarf added this to the 2024-Q4 milestone Nov 15, 2024
@hilmarf hilmarf added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Nov 15, 2024
frewilhelm
frewilhelm previously approved these changes Nov 15, 2024
@jakobmoellerdev
Copy link
Contributor Author

This cannot be merged until the step is removed.

… care of patch and release branches get bumped too via minor
Copy link
Contributor

@frewilhelm frewilhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (even though I have to admit that this whole generate-version scripts/programs are really confusing)

@jakobmoellerdev
Copy link
Contributor Author

Understood. If you could let me know how we can improve them, please tell me straight away. I will try to simplify as much as possible but currently my PRs are focusing on only "touching up" without rewriting

@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) November 15, 2024 20:49
@jakobmoellerdev jakobmoellerdev merged commit bb7c5f7 into open-component-model:main Nov 15, 2024
17 checks passed
@frewilhelm
Copy link
Contributor

I created an issue #1094. Although I agree, that this has no priority.

@hilmarf hilmarf added the kind/chore chore, maintenance, etc. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc.
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

3 participants