Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust v3alpha1 schema version #553

Merged

Conversation

fabianburth
Copy link
Contributor

Description

So far, if one wanted to Encode/Decode a Component Descriptor to v3alpha1, this had to be specified with the corresponding constant v3alpha1.GroupVersion while for v2, this had to be specified with the corresponding constant v2.SchemaVersion.

This behaviour is quite confusing and should therefore be adjusted.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@mandelsoft mandelsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in package compdesc (file compdesc_test.go line 89) the calculation of the expected
scheme version still has to be adapted.

Please check, whether this is the only place where the SchemeVersion variable is used.

  • compdesc_test.go
  • cmd_test.go in .../ocmcmds/components/get

@fabianburth fabianburth force-pushed the v3alpha1-schema-version branch from 2a14809 to cadc156 Compare October 24, 2023 13:39
@mandelsoft mandelsoft merged commit 7af2f40 into open-component-model:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants