-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composition support #561
Merged
Merged
composition support #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliminate the hybrid handling for access methods: - as provided by the access type: non-dup - explicit method view interface with dup and wrapper introducing the dup. Now, the cosumer view is just the AccessMethos interface providing ref counting and Dup. The old interface is just the implementation interface AccessMethodImpl, now. It must be wrapped ba an access method provider using a cpi function into a regular AccessMethod object before returning it to the consumer. ATTENTION: for regular consumers of the intreface, this is transparent, but type casts to the implementation type is not possible anymore. If there is internal coding urgently requiring access to the implementation, there is a cpi function GetAccessMethodImplementation.
fabianburth
previously approved these changes
Nov 6, 2023
fabianburth
previously approved these changes
Nov 7, 2023
fabianburth
previously approved these changes
Nov 7, 2023
fabianburth
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the composition repository. It is a memory based repository
using the referenz feature of blobs to keep blob accesses in memory and keep
external resources as long as the blob is still in use by the repository.
This feature is used to support memory based composition component versions
existing without a backing storage like an OCI registry.
The
AddVersion
methods on repositories are extended to work with anycomponent version, not only the ones, which are backed by the same repository.
This allows copying component versions directly with the core API without
the need of transferring it. This requires some simple transfer login
in the core api. The generic component view wrapper now implements
the transfer of local blobs when adding a component version from another repository.
Therefore it uses the traditional
StoreBlob
method also used by the transfer tool.A
Resource/SourceAccess
can now be added directly to a component version.The access spec/method provided by those accesses is now optional, but always
the
BlobAccess
mthod must implemented. The newSetResource/SourceAccess
.implicitly add a local blob if there is no access spec provided, or local access spec.
Otherwise the access spec is used.
This makes it possible to provide implementations of a
ResourceAccess
andSourceAccess
without a backing component version, which either specifies an access spec or blob
based content. This is used by the new package
elements
, which provides option basedbuilders for Resource/Source Access implementation describing technology-specific
blob-based and access-base instances, which can the be added to a component version.
Additionally, there lots of fixes to solve problems, which occurred during the introduction
of the new elements.
To continue with the cleanup of the package structure some packages are moved to up
and the old functions/methods are deprecated.
FInally, there is a complete example for an end-to-end scenario for providing and publishing
a component version and consuming this version is a target environment with transport,
localization and deployment.
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: