Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault Credentials Repository #563

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Nov 2, 2023

Description

This PR provides a first version to support HashiCorp Vault as credentials repository for the OCM toolset.

It supports the Key-Value secret engine, only. so far.
Automatic propagation of consumer ids is supported by using the custom meta data feature of the key/value store.

Supported Auth methods are token and approle.

Additionally, the RepositoryType interface for the credential context has been extended to support descriptions.
This way the CLI docu now provides information about the supported credential repository types and their specification format
fields similar to the AccessMethod type descriptions.

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #540

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mandelsoft mandelsoft merged commit 2b35045 into open-component-model:main Nov 3, 2023
@mandelsoft mandelsoft deleted the vault branch November 3, 2023 16:00
@morri-son morri-son added kind/epic Large multi-story topic area/ipcei Important Project of Common European Interest and removed kind/epic Large multi-story topic labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei Important Project of Common European Interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement additional credential repository for Hashicorp's Vault
2 participants