duplicate detection for add commands #564
Conversation
| return list.Result() | ||
| } | ||
|
|
||
| func ValdateElementSpecIdentities(kind string, src string, elems []ElementSpec) error { |
There was a problem hiding this comment.
typo
| func ValdateElementSpecIdentities(kind string, src string, elems []ElementSpec) error { | |
| func ValidateElementSpecIdentities(kind string, src string, elems []ElementSpec) error { |
| @@ -279,6 +283,39 @@ func Validate(r *ResourceInput, ctx inputs.Context, inputFilePath string) error | |||
| return allErrs.ToAggregate() | |||
| } | |||
|
|
|||
| func ValdateElementIdentities(kind string, elems []Element) error { | |||
There was a problem hiding this comment.
typo
| func ValdateElementIdentities(kind string, elems []Element) error { | |
| func ValidateElementIdentities(kind string, elems []Element) error { |
| return list.Result() | ||
| } | ||
|
|
||
| func ValdateElementSpecIdentities(kind string, src string, elems []ElementSpec) error { |
There was a problem hiding this comment.
What is the src string supposed to be?
Please choose a more tangible parameter name or add helpful comments.
There was a problem hiding this comment.
added doc to various types and functions
| list.Add(addhdlrs.ValdateElementSpecIdentities("resource", elem.Source().String(), generics.ConvertSliceTo[addhdlrs.ElementSpec](r.Resources))) | ||
| list.Add(addhdlrs.ValdateElementSpecIdentities("source", elem.Source().String(), generics.ConvertSliceTo[addhdlrs.ElementSpec](r.Sources))) | ||
| list.Add(addhdlrs.ValdateElementSpecIdentities("reference", elem.Source().String(), generics.ConvertSliceTo[addhdlrs.ElementSpec](r.References))) |
There was a problem hiding this comment.
What is an elements source (elem.Source())? Confusing name (especially since "Sources" actually are a core model element - is the core model element related to this function? If so, how?)
The package addhdlrs (where this function is from) contains generally quite generic coding with non-tangible namings and no comments to support the understanding.
| @@ -155,6 +155,10 @@ type ResourceSpec struct { | |||
|
|
|||
| var _ addhdlrs.ElementSpec = (*ResourceSpec)(nil) | |||
|
|
|||
| func (r *ResourceSpec) GetRawIdentity() metav1.Identity { | |||
| return metav1.NewIdentity(r.Name, metav1.SystemIdentityVersion, r.Version) | |||
There was a problem hiding this comment.
Why is this constant called SystemIdentityVersion?
There was a problem hiding this comment.
SystemIdentityVersion and SystemIdentityName are the two predefined identity properties use to identify elements (resources, sources, referebces) in CDs.
There was a problem hiding this comment.
added docu to their const definitions.
Description
The add commands now check for duplicate ids for resources, sources and references in specs and report
appropriate problems with the location in the source yaml files.
The same check is done for adding multiple components to avoid overwrite of components from the same action.
The CD validation now reports the identity of the validated component version, if the validation fails.
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: