Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only have yaml out put on stdout if dryrun is enabled #780

Merged
merged 1 commit into from
May 27, 2024

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 27, 2024

Description

open-component-model/ocm-project#67

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸŽ‡ Restructuring
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/s Small label May 27, 2024
Copy link
Contributor

github-actions bot commented May 27, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 4
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

Copy link
Contributor

ocmbot bot commented May 27, 2024

Integration Tests for b835e96 run with result: Success βœ…!

hilmarf
hilmarf previously approved these changes May 27, 2024
@Skarlso Skarlso force-pushed the produce-valid-yaml branch from 196924f to 84ff4a3 Compare May 27, 2024 13:02
@Skarlso Skarlso requested a review from hilmarf May 27, 2024 13:02
Copy link
Contributor

ocmbot bot commented May 27, 2024

Integration Tests for b835e96 run with result: Success βœ…!

@Skarlso Skarlso merged commit ab463b2 into main May 27, 2024
15 checks passed
@Skarlso Skarlso deleted the produce-valid-yaml branch May 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Small
Projects
Status: πŸ”’Closed
Development

Successfully merging this pull request may close these issues.

2 participants