New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonatype nexus - quirks modes #782

Merged

hilmarf merged 24 commits into main from npm/nexus

May 29, 2024

Member

hilmarf commented May 28, 2024

Description

Two step token auth doesn't work with Nexus and the REST endpoint for a dedicated version doesn't exist. With this PR, Read-Access is done only via Basic-Auth and in case the specified version endpoint is not found, it will now try to load the complete package description from one level above. That should contain ALL existing versions, incl. the requested one.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes Credentials for npm repositories have no effect #753 and npm support does not work with nexus #769

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help
Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

📜 README.md
🙅 no documentation needed

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

hilmarf added 6 commits

May 17, 2024 14:35


          refactor npm

0c88d31


          Merge branch 'main' into npm/nexus

50af79f


          Merge branch 'main' of github.com:open-component-model/ocm into npm/n…

5341bef

…exus


          Merge branch 'main' of github.com:open-component-model/ocm into npm/n…

428c0bf

…exus


          Merge branch 'main' of github.com:open-component-model/ocm into npm/n…

b963e31

…exus


          fixes:

0369f29

#769
and
#753

github-actions bot added the size/m label

hilmarf linked an issue

that may be closed by this pull request

npm support does not work with nexus #769

Closed

Contributor

github-actions bot commented May 28, 2024 •

edited

Loading

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION	NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES	0
MAJOR UPDATES AVAILABLE	0
LICENSE REQUIRES REVIEW	4
HIGH RISK LICENSES	9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY	0

Detailed Logs: mend-scan-> Generate Report
Mend UI

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!

hilmarf added 3 commits

May 28, 2024 12:26


          fix test

c177391


          errors.New

7e358c3


          docs

3eff64d

hilmarf marked this pull request as ready for review

May 28, 2024 10:28

hilmarf requested review from Skarlso, mandelsoft and fabianburth

May 28, 2024 10:28

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!

rm

d9e5251

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!


          support of 'sha-1:'

e5e52ac

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!


          sha1 generic test

7ed8854

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!

Skarlso reviewed

View reviewed changes

pkg/iotools/digests.go Outdated Show resolved Hide resolved

Skarlso reviewed

View reviewed changes

pkg/iotools/digests_test.go Show resolved Hide resolved


          keep regex - compile only once

e0cd11a

hilmarf requested a review from Skarlso

May 28, 2024 14:29

Skarlso reviewed

View reviewed changes

pkg/contexts/credentials/builtin/npm/identity/identity.go Show resolved Hide resolved

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!

Skarlso reviewed

View reviewed changes

pkg/contexts/credentials/builtin/npm/identity/identity.go Outdated Show resolved Hide resolved


          lint

f5a091a

Skarlso reviewed

View reviewed changes

pkg/contexts/ocm/accessmethods/npm/method.go Outdated Show resolved Hide resolved


          not using '.'/dot imports

646ef4a

Skarlso reviewed

View reviewed changes

pkg/contexts/ocm/accessmethods/npm/method.go Outdated Show resolved Hide resolved

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!


          limiting might reader, might result in broken json

c89d584

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!


          comment on workaround hack

e4c8d4e

Skarlso reviewed

View reviewed changes

pkg/contexts/ocm/accessmethods/npm/method.go Outdated Show resolved Hide resolved

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!


          add missing reader.Close() where possible

2de325e

Contributor

ocmbot bot commented May 28, 2024

Integration Tests for ab463b2 run with result: Success ✅!

hilmarf requested a review from Skarlso

May 28, 2024 15:44

mandelsoft reviewed

View reviewed changes

pkg/contexts/credentials/repositories/npm/config_test.go Outdated Show resolved Hide resolved

pkg/contexts/ocm/accessmethods/npm/method.go Outdated Show resolved Hide resolved


          Merge branch 'main' into npm/nexus

02f281a

Contributor

ocmbot bot commented May 29, 2024

Integration Tests for 509ba89 run with result: Success ✅!

hilmarf added 3 commits

May 29, 2024 08:51


          use Must

c54f004


          PackageUrl() + PackageVersionUrl() handle dangling '/'

cf6d87b


          resp.Body.Close()

0aa2829

hilmarf requested a review from mandelsoft

May 29, 2024 07:40

Contributor

ocmbot bot commented May 29, 2024

Integration Tests for 509ba89 run with result: Success ✅!

hilmarf added 2 commits

May 29, 2024 15:00


          strings.TrimSuffix

43fd92f


          Merge branch 'main' into npm/nexus

facb163

Contributor

ocmbot bot commented May 29, 2024

Integration Tests for ba23b9f run with result: Success ✅!

mandelsoft approved these changes

View reviewed changes

hilmarf merged commit 862458c into main

15 checks passed

hilmarf deleted the npm/nexus branch

May 29, 2024 13:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m