Fix make cmds #810
Merged
Fix make cmds #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
force-pushed
the
fix-make-cmds
branch
from
c9b02b9 to
cda6d2b
Compare
fabianburth
force-pushed
the
fix-make-cmds
branch
from
cda6d2b to
3edc1b5
Compare
Skarlso
reviewed
Jun 10, 2024
fabianburth
force-pushed
the
fix-make-cmds
branch
from
1f0da23 to
5f246a7
Compare
hilmarf
reviewed
Jun 11, 2024
fabianburth
force-pushed
the
fix-make-cmds
branch
from
5f246a7 to
79b52dd
Compare
hilmarf
reviewed
Jun 12, 2024
fabianburth
force-pushed
the
fix-make-cmds
branch
3 times, most recently
from
531897d to
835b4ca
Compare
hilmarf
previously approved these changes
Jun 13, 2024
This was referenced Jun 13, 2024
… in the Makefile)
fabianburth
force-pushed
the
fix-make-cmds
branch
from
22f397c to
7fa415f
Compare
mandelsoft
previously approved these changes
Jun 13, 2024
mandelsoft
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
gcitomake install-requirements. This fixes a bug in thegci writecommands which lead to theslicesimport being wrongly sorted which mademake formatand alsomake prepareessentially unusable.During the adjustment, I also changed
make test-alltomake testand the previousmake testtomake unit-test. I think the default should be to run all tests (currently, they dont take too long anyway).