Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm input type #886

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat: add npm input type #886

merged 3 commits into from
Aug 23, 2024

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Aug 22, 2024

What this PR does / why we need it

Adds the npm input type.

Which issue(s) this PR fixes

Closes open-component-model/ocm-project#199

TODOs

  • add file based registry test
  • add some more documentation

@github-actions github-actions bot added the size/m Medium label Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 4
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 3
HIGH RISK LICENSES 10
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

Copy link
Contributor

ocmbot bot commented Aug 22, 2024

Integration Tests for db6c953 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 22, 2024

Integration Tests for db6c953 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 23, 2024

Integration Tests for db6c953 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 23, 2024

Integration Tests for db6c953 run with result: Success ✅!

@Skarlso Skarlso marked this pull request as ready for review August 23, 2024 09:50
@hilmarf hilmarf added this to the 2024-Q3 milestone Aug 23, 2024
hilmarf
hilmarf previously approved these changes Aug 23, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the:

TODO: try out a file based NPM registry for testing.

Copy link
Contributor

ocmbot bot commented Aug 23, 2024

Integration Tests for e46befa run with result: Success ✅!

@hilmarf hilmarf enabled auto-merge (squash) August 23, 2024 10:44
Copy link
Contributor

ocmbot bot commented Aug 23, 2024

Integration Tests for e77f8c6 run with result: Success ✅!

@hilmarf hilmarf merged commit f2dec73 into main Aug 23, 2024
19 checks passed
@hilmarf hilmarf deleted the add-npm-access branch August 23, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m Medium
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Input Type for NPM Access
2 participants