Support standard object types for command plugins + options for templater types #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
requested changes
Oct 14, 2024
fabianburth
reviewed
Oct 14, 2024
fabianburth
approved these changes
Oct 14, 2024
Skarlso
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ater types (#958) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it - Support standard object types for command plugins The CLI supports verbs on objects (e.g, get component). For such object names aliases are used (e.g. for componentversions, it is possible to use component or cv, instead) A CLI command provided by a plugin may use such a standard object name. The new integration takes the aliases provided by the CLI into account. - Options for templater types Templaters are used by the CLI to process the constructor files, but possible also by direct lib users. So far, templaters are created for a value set, but without other arbitrary type specific optional parameters. The templater configuration now offers settings passed to the templater constructor. This is used by spiff to enable or restrict the OS mode. By default, file system access is enabled,. OS access is enabled if no virtual filesystem is used. With this configuration option, the user of the templater may configure tis behaviour. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The CLI supports verbs on objects (e.g, get component). For such object names aliases are used
(e.g. for componentversions, it is possible to use component or cv, instead)
A CLI command provided by a plugin may use such a standard object name. The new integration takes the aliases provided
by the CLI into account.
Templaters are used by the CLI to process the constructor files, but possible also by direct lib users.
So far, templaters are created for a value set, but without other arbitrary type specific optional parameters.
The templater configuration now offers settings passed to the templater constructor. This is used by spiff
to enable or restrict the OS mode. By default, file system access is enabled,. OS access is enabled if no virtual filesystem
is used. With this configuration option, the user of the templater may configure tis behaviour.
Which issue(s) this PR fixes