Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frame definition and acquisition counter definition #57

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

aacuevas
Copy link

(note: the TODO admonition on the acquisition counter it's there for us so we do not forget. Handling cross references between multiple PRs is hard, so until we have a better way, this is a good way to mark "there should be a cross reference to some other page that will be finished in a different PR")

Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@aacuevas
Copy link
Author

Comments addressed

@jonnew jonnew merged commit 3cb24c0 into oni-v2 Nov 22, 2024
@jonnew jonnew deleted the issues-55-and-56 branch November 22, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants