✨ Add iban and licenseplate component

[Viicos]

No description provided.

[Viicos]

The type definition of licenseplate seems to be incorrect:

export interface LicensePlateProperties {
    type: 'licenseplate';
    validate: {
        pattern: '^[a-zA-Z0-9]{1,3}\\-[a-zA-Z0-9]{1,3}\\-[a-zA-Z0-9]{1,3}$';  // Should also extend OFValidateOptions?
    };
    validateOn: 'blur';
}

Also, I've removed readonly input checkboxes in last commit for these two components, but I don't see any reference to that attribute in the types, nor in the base formio types?

[sergei-maertens]

The type definition of licenseplate seems to be incorrect:

export interface LicensePlateProperties {
    type: 'licenseplate';
    validate: {
        pattern: '^[a-zA-Z0-9]{1,3}\\-[a-zA-Z0-9]{1,3}\\-[a-zA-Z0-9]{1,3}$';  // Should also extend OFValidateOptions?
    };
    validateOn: 'blur';
}

Also, I've removed readonly input checkboxes in last commit for these two components, but I don't see any reference to that attribute in the types, nor in the base formio types?

Good catch, something seems to have gone wrong there. We should at least check the type tests to see if those also highlight the issue. There may be a forgotten intersection or something like that.

[Viicos]

Hum, there's a test for this and it seems to pass

[sergei-maertens]

Hum, there's a test for this and it seems to pass

interesting 🤔

[sergei-maertens]

Spotted a couple of oversights.

[sergei-maertens]

I'm surprised the type checker didn't complain about this one though

[Viicos]

It seems types are incorrect: defaultValue is not excluded. But Iban is multiple capable, so according to the definition of MultipleCapable, it would infer never if we Omit defaultValue on the BaseIbanComponentSchema :/

placeholder doesn't seem to be Omit'ed as well

[sergei-maertens]

defaultValue is something we can't/shouldn't omit since formik needs to have one in the renderer anyway, so it can be present in the component definition but not exposed in the form builder

placeholder should be omitted, feel free to file an issue in the types repo